buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services

MIT License

3.1k stars 186 forks source link

sso: update go modules #273

Closed Jusshersmith closed 4 years ago

Jusshersmith commented 5 years ago

Problem

Updates to certain go modules are required. This is starting to cause errors with new builds: https://circleci.com/gh/buzzfeed/sso/2185?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Solution

Running https://github.com/buzzfeed/sso/blob/master/scripts/test locally edited go.mod and go.sum files as required.

mccutchen commented 5 years ago

Should we also add -mod=readonly to the go build commands in our Dockerfile and Makefile to more explicitly require up-to-date module information?

Jusshersmith commented 4 years ago

Yeah, I think that sounds like a sensible idea @mccutchen!

codecov[bot] commented 4 years ago

Codecov Report

Merging #273 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   62.21%   62.21%           
=======================================
  Files          54       54           
  Lines        4200     4200           
=======================================
  Hits         2613     2613           
  Misses       1399     1399           
  Partials      188      188

Jusshersmith commented 4 years ago

Think I'm going to need a fresh review on this @mccutchen! (thanks!)