search

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services
MIT License
3.07k stars 187 forks source link

sso_proxy: allow empty slice of groups #289

Closed Jusshersmith closed 4 years ago

Jusshersmith commented 4 years ago

Problem

See https://github.com/buzzfeed/sso/pull/286

Solution

This implements the initial fix described in https://github.com/buzzfeed/sso/pull/286. I think there may be a couple extra edge cases we need to cover in that pull request, so I've pulled out the fix here so it can be applied separately.

codecov[bot] commented 4 years ago

Codecov Report

Merging #289 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   61.85%   61.87%   +0.01%     
==========================================
  Files          57       57              
  Lines        4638     4640       +2     
==========================================
+ Hits         2869     2871       +2     
  Misses       1556     1556              
  Partials      213      213
Impacted Files Coverage Δ
internal/proxy/providers/sso.go 68.84% <100.00%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b956e9...565ab66. Read the comment docs.