search

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services
MIT License
3.07k stars 187 forks source link

Create Updated Docker Image #311

Closed dpeckett closed 3 years ago

dpeckett commented 3 years ago

The Docker image has not been rebuilt since the last release in 2019, this means it contains a variety of security erratas.

Can you perform a new Docker build or create a new release of the project.

matthias-kloeckner commented 3 years ago

just asking kindly: do you have an estimation for this?

Jusshersmith commented 3 years ago

Apologies for the slow turnaround here. I'll look to publish a new release by the end-of-day Friday, however likely sooner.

Thank you for your patience!

Jusshersmith commented 3 years ago

Just in case it was missed, a new 3.0.0 version was released earlier today. This includes a variety of changes, including large alterations to the configuration variables used by sso_proxy, so please take care while updating. 🙂

mirobertod commented 3 years ago

@Jusshersmith thank you for the new release

It looks like after upgrade to v3.0.0 all the requests end up with the 421 Misredirect request; even the quickstart is not working anymore.

Jusshersmith commented 3 years ago

Hey @mirobertod.

If you change https://github.com/buzzfeed/sso/blob/main/quickstart/docker-compose.yml#L37 to use the key UPSTREAM_CONFIGFILE, and restart the containers, does that help at all? (note the S has been removed in 'CONFIGFILE').

That was also incorrect in the table provided in https://github.com/buzzfeed/sso/pull/279, which has now been changed. I'll touch that up elsewhere too asap.

mirobertod commented 3 years ago

Hi @Jusshersmith I can confirm that now using the env var UPSTREAM_CONFIGFILE without the S is working fine.

Thanks

Jusshersmith commented 3 years ago

Great! A fix has been opened: https://github.com/buzzfeed/sso/pull/315.

Please do open up a new issue if you run into any other errors. Now that the release is out, I'll close this one 👍