search

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services
MIT License
3.07k stars 187 forks source link

quickstart - rename CLUSTER to UPSTREAM_CLUSTER #314

Closed mirobertod closed 3 years ago

mirobertod commented 3 years ago

Problem

quickstart is not fully updated with the new variables name introduced with the v3.0.0

Solution

rename CLUSTER to UPSTREAM_CLUSTER in sso-proxy remove CLUSTER from sso-auth. it looks like is not used anymore (https://github.com/buzzfeed/sso/blob/main/internal/auth/configuration.go)

codecov[bot] commented 3 years ago

Codecov Report

Merging #314 (36c4a86) into main (8ebaa86) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files          58       58           
  Lines        4286     4286           
=======================================
  Hits         2689     2689           
  Misses       1382     1382           
  Partials      215      215

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ebaa86...36c4a86. Read the comment docs.