pkg/logging: Use RFC3339 compatible time format

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services

MIT License

3.07k stars 187 forks source link

pkg/logging: Use RFC3339 compatible time format #335

Open namm2 opened 1 year ago

namm2 commented 1 year ago

Signed-off-by: Nam Hai Nguyen namhai.nguyen-ext@commercetools.com

Problem

Logging pkg doesn't use either RFC3339 or ISO 8601 time format, then we have to parse SSO logs specifically.

Solution

Use a valid RFC 3339 time format.

Referece: https://ijmacd.github.io/rfc3339-iso8601/

Notes

Other pertinent information. Examples: a walkthrough of how the solution might work, why this solution is optimal compared to other possible solutions, or further TODOs beyond this PR.

svenmueller commented 1 year ago

How can we get a PR like this reviewed and merged? @sporkmonger @mcfearsome @joelsouza @benjsto