search

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services
MIT License
3.07k stars 187 forks source link

INFRA-13603/INTAKE-398: Revert "sessions pkg: omit domain attribute in session cookie" #351

Closed danbf closed 2 months ago

danbf commented 2 months ago

Reverts buzzfeed/sso#329

matches https://github.com/buzzfeed/mono/pull/74585

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.94%. Comparing base (e960749) to head (c24a9da).

Files Patch % Lines
internal/pkg/sessions/cookie_store.go 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ======================================= Coverage 62.93% 62.94% ======================================= Files 58 58 Lines 4757 4758 +1 ======================================= + Hits 2994 2995 +1 Misses 1546 1546 Partials 217 217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.