search

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services
MIT License
3.07k stars 187 forks source link

*: statsd should be optional #5

Open loganmeetsworld opened 5 years ago

loganmeetsworld commented 5 years ago

Not all environments may have need for metrics collection, as such the following options should be optional or have defaults:

eriksw commented 5 years ago

Would work to expose metrics for pulling by Prometheus ever be accepted? At my work we've been eliminating our statsd infrastructure and while sso looks promising, the fact that its metrics are statsd (pushed) instead of pull/scrape-based is a big :-1:.

loganmeetsworld commented 5 years ago

@eriksw yes! We have looked into using Prometheus as well. Ideally we'd love to support both. Contributions on this front are more than welcome!

sporkmonger commented 5 years ago

Similarly need Prometheus metrics rather than statsd. I may be able to tackle this.

sporkmonger commented 5 years ago

I will probably take a first pass at simply setting up a set of statsd_exporter mappings for Prometheus as that doesn't require code changes.

namliz commented 5 years ago

@sporkmonger How's it going with that? I'd also be happy to contribute Prometheus support, and metrics should absolutely be optional. I just don't want to tackle it if you're on it.