search

buzzn / core

Die Kraft der Gemeinschaft
GNU Affero General Public License v3.0
1 stars 0 forks source link

Serve correct HTTP codes #1453

Closed mguentner closed 5 years ago

mguentner commented 6 years ago

the application renders HTTP 200 for all successful requests, however for POST 201 and for DELETE 204 make more sense.

Also see https://github.com/buzzn/core/tree/http-status-405 for 405 instead of 404 if a method with the same route exist.

mkristian commented 6 years ago

@mguentner see https://github.com/buzzn/core/blob/master/lib/buzzn/roda/helpers/serializer.rb#L11-L17 and find out where this is not sufficient. all endpoints test the status as well.