search

bvaisvil / zenith

Zenith - sort of like top or htop but with zoom-able charts, CPU, GPU, network, and disk usage
MIT License
2.68k stars 69 forks source link

Crates.io and `cargo install zenith` #5

Open rrichardson opened 4 years ago

rrichardson commented 4 years ago

This is really slick! I spend way too much of my time administering and monitoring machines. I like the UX of this, it gives me the numbers I care about in an intuitive way.

I would like to be able just cargo install zenith on machines.

This means you'll need to work something out with the owner of https://crates.io/crates/zenith or rename this.

bvaisvil commented 4 years ago

Thank you for the feedback! I'd love to publish on crates.io. Not sure the other project with that is under active development. Perhaps I'll reach out. Another issue is that I'm using a forked version of sysinfo that adds per process disk usage. I've got a pr open for that but it hasn't yet been merged.

karuppiah7890 commented 4 years ago

Dumb question: Should the repo name and crate name be the same? 🤔 We could use different name in the crate right? Sorry, a newbie here, if that seems too dumb

bvaisvil commented 4 years ago

@karuppiah7890 That's a good point, I haven't really explored that.

I'll still need to either publish my own version of sysinfo into crates.io (don't like this idea), have my changes accepted or get the info from another library.

apiraino commented 4 years ago

I second this. I had read about zenith on a blog, executed cargo install zenith and then launched it. Got a weird output and came here to look for a bug report or more instructions.

I am dumb but it's too easy to install and launch the wrong binary (possibly executing something malicious).

rrichardson commented 4 years ago

The executable name doesn't have to match the crates.io name, but I think it has to match the Cargo.toml project name.

Ripgrep is a good example. Cargo install ripgrep gives you a binary called rg

My recommendation would be to create a uniquely named project in crates.io. Maybe zenith-monitor or something, but the binary can still be named zenith

bvaisvil commented 4 years ago

Immediate issue blocking progress on this is my git dependency on my own fork of the sysinfo crate.

ghost commented 3 years ago

Is there something special about your sysinfo fork that doesn't apply to the heim crate that you're also specifying a git repo for? I'm not understanding why this being a fork is a blocker.

bvaisvil commented 3 years ago

The heim crate is a git dependency because I needed a fix before an official release (still the case). I have made fixes and enhancements to sysinfo that I haven't yet made PRs for.

ghost commented 3 years ago

I understand the heim crate git dependency. I'm asking why you can't do the same with the sysinfo crate, since they're both on github. I must be missing something, I'm trying to find out what it is.

bvaisvil commented 3 years ago

For example,

ghost commented 3 years ago

Right. I understand that. I think I'm not being clear. I'm sorry. What I mean is: what breaks with sysinfo if you publish zenith to crates.io as-is? What does having your own fork of sysinfo break when you do that? This is what I don't understand.

bvaisvil commented 3 years ago

You can't publish to crates.io with git dependencies.

ghost commented 3 years ago

Ahh! Thank you! That explains everything.

clouds56 commented 9 months ago

Is it still blocking after https://github.com/GuillaumeGomez/sysinfo/pull/287 was merged