search

bvanheu / pytoutv

TOU.TV client library and user interfaces written in Python 3
96 stars 23 forks source link

Print Episode Title instead of generic title #123

Open danyboy666 opened 6 years ago

danyboy666 commented 6 years ago

For some reason when I pulled the last version the full episode title isn't displayed anymore.

`db666@homeshare:~$ toutv info "Les grands reportages" S24E02 Les grands reportages La course vers l'intelligence artificielle [S24E02]

Ce documentaire australien démontre comment l'intelligence artificielle va changer notre travail, car de nouvelles recherches montrent combien de ce que nous faisons pourrait être fait par des robots.

Infos:

Air date: 2018-01-03 Available qualities: 461 kbps (480x270) 561 kbps (512x288) 925 kbps (640x360) 1324 kbps (852x480) 2124 kbps (852x480)`

This is what the script pull with the lastest version:

`torrent@homeseedbox:~/script$ toutv info "Les grands reportages" S24E02 Les grands reportages Épisode 02 [S24E02]

Ce documentaire australien démontre comment l'intelligence artificielle va changer notre travail, car de nouvelles recherches montrent combien de ce que nous faisons pourrait être fait par des robots.

Infos:

I'm working on a script wich compare data from toutv and tvdb and automaticaly match and rewrite the tag with proper SXXEXX. Fetching the episode name directly from pytoutv and comparing that with the database would simplify alot of what i'm doing on my side :).

simark commented 6 years ago

There must be something that changed in the data we receive from the server, because I can't find the title at all in the data we receive from the server. This is the request we do to get info on an episode:

https://github.com/bvanheu/pytoutv/blob/master/toutv/transport.py#L125

We probably need to re-check what requests the latest Android or iPhone application does, and see if there would be something more appropriate, with the information we want.

danyboy666 commented 6 years ago

It's definitly the code I have two different versions of pytoutv running and they interpret the episode name differently as the exemple.

simark commented 6 years ago

Ok, interesting. Do you know which commit is the version that works from? Or at least the version (toutv --version)?

danyboy666 commented 6 years ago

Yeah I updated that version sadly. I know it's a really old version, one year+. I'll try to find a way to revert to that version or get the pull history if that's even possible. I know I installed that and never pulled the last commits until sometime last week or so.

danyboy666 commented 6 years ago

`dbtech@DB-TECH-SRV0001:~$ toutv info "Les grands reportages" S24E02 Les grands reportages La course vers l'intelligence artificielle [S24E02]

Ce documentaire australien démontre comment l'intelligence artificielle va changer notre travail, car de nouvelles recherches montrent combien de ce que nous faisons pourrait être fait par des robots.

Infos:

`

danyboy666 commented 6 years ago

dbtech@DB-TECH-SRV0001:~/pytoutv$ toutv --version toutv v2.3.0

danyboy666 commented 6 years ago

it's version dating just a little over a year.

So yeah v2 can return the proper episode title.

danyboy666 commented 6 years ago

dbtech@DB-TECH-SRV0001:~/pytoutv$ toutv login $user $password usage: toutv [-h] [-n] [-v] [-V] {list,info,search,fetch,clean} ... toutv: error: argument command: invalid choice: 'login' (choose from 'list', 'info', 'search', 'fetch', 'clean')

Damn I can't login to dl 720p content with this version :/

danyboy666 commented 6 years ago

I think you might be right after all. It may have something to do with the data the server returns. I noticed in your version 2.3 that you call toutv api v1. If you call api v2 in the latest release the data might not be formatted the same.

simark commented 6 years ago

That's still a regression for the pytoutv end user, who doesn't care about what API we use. It should be fixed (although I can't guarantee I'll be able to spend some time on it soon).

Thanks for the report.

danyboy666 commented 6 years ago

Sounds good. I can pull the episodes info directly from the json data for now it'll will do the trick for me.

Sent from my Samsung Galaxy smartphone.

-------- Original message -------- From: Simon Marchi notifications@github.com Date: 2018-01-25 9:24 AM (GMT-05:00) To: bvanheu/pytoutv pytoutv@noreply.github.com Cc: danyboy666 dany.ferron@outlook.com, Author author@noreply.github.com Subject: Re: [bvanheu/pytoutv] Print Episode Title instead of generic title (#123)

That's still a regression for the pytoutv end user, that doesn't care about what API we use. It should be fixed (although I can't guarantee I'll be able to spend some time on it soon).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbvanheu%2Fpytoutv%2Fissues%2F123%23issuecomment-360480849&data=02%7C01%7C%7C29178a0672024c53426708d563ff4a46%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636524870462517522&sdata=vtqqcl434YceugbtmgBqGNujkUeZL5n8zqahpr5Hl88%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH9XmlgqcYqtBIGvE-lTXFVpHj9zlPxWks5tOI6EgaJpZM4RsNlP&data=02%7C01%7C%7C29178a0672024c53426708d563ff4a46%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636524870462517522&sdata=XghKBJ5WfJ5sI781rd0mhtgD7XYmOQIiU%2Bvs4OQ5DHw%3D&reserved=0.