Closed anthonydahanne closed 5 years ago
@simark I've adressed your comments. Wrt the Dockerfile changes, we'll need to wait for this PR to be merged and me changing the Dockerfile location in Dockerhub before we can see the image anthonydahanne/toutv updated.
Thanks. Could you please squash your commits in a single one?
ok
done
ah ! apparently I can't have anthonydahanne/toutv build point to this github repo, since I'm not an owner of the repo (or a member of the org owning the repo)... hum... could you create an account on Dockerhub to link to this Github repo ? If needed, I could walk you through it
I already have a dockerhub account, do I need to make a new one just for this?
Alternatively, would it work if I gave you some permissions on this repo, so you can retain the ownership of the docker repository?
I already have a dockerhub account, do I need to make a new one just for this?
If you use your personal github account, you'll have to create a simark/toutv dockerhub repo; actually I'm not even sure you can; it all comes down to how dockerhub links to github accounts
Alternatively, would it work if I gave you some permissions on this repo, so you can retain the ownership of the docker repository?
sure, but I don't know what kind of permissions are required.
I'd think having an org would help, but maybe we can work something with personal accounts and permissions - we could chat about it on hangout, I'm anthony point dahanne arobase gmail point com
Sorry I took a bit of time to come back to this.
I created a pytoutv org with a pytoutv repository and added you as an owner:
I uploaded a build tagged v3.0.2, can you check if it works for you?
hello @simark ; you created a repository that is not an automated build.
It needs to be an automated build, so that it will be build automatically by Docker Hub infra after any new commits.
Please delete this repository, and create a new "automated build", then configure it so that it picks up the Dockerfile under the docker/ folder
Here is a screenshot, let me know if oyu have any questions (you gave eme rights on Dockerhub, but I can't link to github.com/bvanheu since I don't have org membership there; but anyway, you're almost there !)
Hmm, even I can only create a build based on my repo (simark/pytoutv). Either @bvanheu needs to create it, or we create a pytoutv github organization and move the official pytoutv repo there. What would you prefer, @bvanheu ?
@simark @bvanheu this dockerhub / github integration seems to prefer an organization - what about a pytoutv organization on Github ? that could help setting up permissions and other things too
CI failed for something not related to my changes !