search

bvanheu / pytoutv

TOU.TV client library and user interfaces written in Python 3
96 stars 23 forks source link

Stop using the v1 API for fetching episode lists #89

Closed simark closed 7 years ago

simark commented 7 years ago

Stop using the old API for getting a episodes of a show, only rely on the new one. Also, make get_emission_episodes return a list instead of a dict.

Fixes #63

gboudreau commented 7 years ago

Removed two more .values() that caused issues with episodes now being a list.

Of note: look at my more_tests branch. This is what I use to locally test the changes I make before committing. That's how I found the one in App. The other one, I found br grepping for .values() in all the project.

simark commented 7 years ago

Thanks for finding this! Yeah, I relied on the static analysis of PyCharm, but you are right that for a dynamically typed language like Python, it can't find everything. We definitely need to have your tests in master (without them being executed by Travis).

toutvqt is most likely not working anymore, it was nice but I didn't have the time to keep it up to date with all the recent changes.