search

bvantagelimited / freeradius_exporter

FreeRADIUS Prometheus Exporter
Apache License 2.0
43 stars 16 forks source link

Add docker compose, docker ignore files #13

Closed shatovilya closed 2 years ago

shatovilya commented 2 years ago

Hey! Added launch via docker + docker ignore to the project so that unnecessary files do not get into the docker image

gen2brain commented 2 years ago

What is the reason you want to add these files? There is already a Dockerfile in the repo, that builds "from scratch", i.e. just binary.

shatovilya commented 2 years ago

I always consider the presence of a docker ignore file to be necessary, even if the final image is scratch. This is a reduction of the image, and a safety net that critical files will not fall into the intermediate or final image. Docker-compose allows you to quickly deploy a service by connecting the project as a git module.

gen2brain commented 2 years ago

In this case, there is no reduction so the file seems just like cruft that doesn't do anything. As for docker-compose, that is more suitable for other repo, the one that will be deployed, used, etc. doesn't add value here it seems. Sorry, not merging.

shatovilya commented 2 years ago

@gen2brain ok!