search

bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

Support search by HOC name #299

Closed bvaughn closed 5 years ago

bvaughn commented 5 years ago

PR #295 removed the HOC portion of the name from element displayName. As a result, you can no longer search by HOC name. We could re-add this by updating the search logic to also check the hocDisplayNames strings.

SavePointSam commented 5 years ago

I’ll take this one! Should be do-able while I’m flying today. :D

bvaughn commented 5 years ago

Sounds good.

SavePointSam commented 5 years ago

@bvaughn, do you also want text highlighting for the Badge like the DisplayName?

bvaughn commented 5 years ago

Not convinced that's worth the effort.

SavePointSam commented 5 years ago

Sound good. PR soon!