search

bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

React Devtools Extension tabs don't show up when Video Downloader Plus extension is enabled #311

Closed mohsinulhaq closed 5 years ago

mohsinulhaq commented 5 years ago

https://chrome.google.com/webstore/detail/video-downloader-plus/fhplmmllnpjjlncfjpbbpjadoeijkogc

React Devtools Experimental tabs don't show up when the above extension is enabled. Logging this as a heads up for potential clashes with other extensions as well.

bvaughn commented 5 years ago

Thanks for the heads up. That extension appears to be writing to __REACT_DEVTOOLS_GLOBAL_HOOK__ which definitely interferes with this extension. I'm not sure what I can do about that really, since that extension isn't controlled by anyone Facebook related.

Going to close this issue since I can't do much about it, but I appreciate you letting me know.

mohsinulhaq commented 5 years ago

Just FYI, original devtools works fine with this extension enabled. I see this issue only when using the new one.

bvaughn commented 5 years ago

Original DevTools implementation is significantly different than the new one, in order to support e.g. reload-and-profile and sharing state (e.g. profiling info) across page navigations. Assuming what you say is true, even if I updated this extension to behave more like the old one, it would still be a race case essentially as to which extension got loaded first. (That extension might still clobber the DevTools extension if it was initialized afterward and override the global hook.)

mohsinulhaq commented 5 years ago

Oh ok, seems reasonable. Thanks for the clarification!