bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

React Native: Remember saved component filters between reloads #337

Closed bvaughn closed 5 years ago

bvaughn commented 5 years ago

DevTools v4 added a pretty powerful new component filtering feature that enables devs to filter out components by type, name, or file system location. Because these filters can be a bit elaborate to create, they are saved between sessions to improve dev experience.

Unfortunately, I don't think I am going to be able to support the persistence functionality for React Native. (In other words, filters will be forgotten each time you reload the app.)

The reason for this is a mix of timing and context. The biggest limiting factor is the lack of a synchronous storage option. React Native has a couple of faux sync storage options, but they just in-memory wrappers around an async storage layer and they require async initialization. That could work if the React Native backend waited to initialize DevTools until it also initialized the async storage layer, but this has implications on reload-and-profile support (#336).

bvaughn commented 5 years ago

This repository is being merged into the main React repo (github.com/facebook/react). As part of this, I am moving all issues to that repository as well and closing them here.

This issue has been relocated to: https://github.com/facebook/react/issues/16470