search

bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

Profiling doesn't work in Firefox #345

Closed bvaughn closed 5 years ago

finico commented 5 years ago

@bvaughn it seems that Safari as well

bvaughn commented 5 years ago

@finico There's no Safari extension. Are you referring to the alpha release of the standalone DevTools? Because profiling works for Safari for me using that version.

finico commented 5 years ago

@bvaughn I've tried at https://react-devtools-experimental.now.sh Profiler shows commits but they're empty (without graph)

bvaughn commented 5 years ago

Ah, gotcha. Thanks for clarifying.

I guess it's not really important for Safari to support the test shell. Really that's just meant as a convenience tool for local development. I assume the underlying cause is probably the same though, so fixing the Firefox (extension) should also fix the Safari demo page :smile:

bvaughn commented 5 years ago

Looks like profiling is working for me on the Firefox extension, using the latest release.

bvaughn commented 5 years ago

The Safari issue isn't related to the Profiler. Looks like the AutoSizer isn't expanding to fill the parent container for some reason. (The height is 0 so the data just doesn't show up.) This nags me a bit, but since Safari isn't an officially targeted browser it's also not a huge concern.

bvaughn commented 5 years ago

Reload and profile seems busted in Firefox :( not sure why

bvaughn commented 5 years ago

Fixed 2f1c100