Closed bvaughn closed 5 years ago
CI is failing because of a Yarn issue, https://github.com/yarnpkg/yarn/issues/7403
At this point, the tests are expected to fail until https://github.com/facebook/react/pull/16139 has landed. This dependency has been removed.
I'm going to go ahead and make this a configurable preference, at least for now. It seems pretty invasive and might turn out to be annoying in ways I haven't accounted for.
I'm going to roll forward with this, since there didn't seem to be any strong concerns (just questions). Please feel free to follow up with me if there are concerns though.
console.error
andconsole.warn
calls.Test with multiple renderersFirst injected renderer wins; console won't be patched for subsequent renderersResolves #347
Related React PR https://github.com/facebook/react/pull/16133
Questions
Is the zero width space character (added in 6a196fd) reasonable or might it cause problems with any instrumented logging of warnings/errors?This is out of DevTools hands since the component stack formatting is now being injected by React.Demo