bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

Patch console to append component stacks #348

Closed bvaughn closed 5 years ago

bvaughn commented 5 years ago

Resolves #347

Related React PR https://github.com/facebook/react/pull/16133

Questions

Demo

Screen Shot 2019-07-15 at 8 52 59 AM

bvaughn commented 5 years ago

CI is failing because of a Yarn issue, https://github.com/yarnpkg/yarn/issues/7403

bvaughn commented 5 years ago

At this point, the tests are expected to fail until https://github.com/facebook/react/pull/16139 has landed. This dependency has been removed.

bvaughn commented 5 years ago

I'm going to go ahead and make this a configurable preference, at least for now. It seems pretty invasive and might turn out to be annoying in ways I haven't accounted for.

toggle-component-stacks-Kapture 2019-07-17 at 9 19 17

bvaughn commented 5 years ago

I'm going to roll forward with this, since there didn't seem to be any strong concerns (just questions). Please feel free to follow up with me if there are concerns though.