search

bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

Feature: tweak search behaviour #353

Closed fanny closed 5 years ago

fanny commented 5 years ago

This pr closes #301

The strategy used here was: Get the first index where elementID is larger than the selected element and reorder the search results for these elements so that the range with the largest is at the beginning of the matrix and the range with the smallest in the end.

fanny commented 5 years ago

I'm sorry for these many commits, I got a little lost on how I could fix an error.

bvaughn commented 5 years ago

No worries. This looks nice. I'll try to find the time to test it soonish.

bvaughn commented 5 years ago

Squash merged via 3a3187f

GitHub isn't picking up on the merge, so I'm going to manually close this PR. Thanks again for contributing!

bvaughn commented 5 years ago

I think the way I merged messed up attributing the fix to you, so I force-pushed master and I'm going to merge through the GitHub UI 😄 I'll just apply my tweak after it's merged.

bvaughn commented 5 years ago

Ok, index change made. Let me know if you see anything funky~