search

bvaughn / react-devtools-experimental

Experimental rewrite of the React DevTools extension
https://react-devtools-experimental.now.sh
MIT License
965 stars 55 forks source link

Don't show "context" for classes without either contextType or contextTypes #368

Closed gaearon closed 5 years ago

gaearon commented 5 years ago
hristo-kanchev commented 5 years ago

I'll take over this one 👍

bvaughn commented 5 years ago

Please hold off for now. Im in the process of merging this repo into the main React repo (https://github.com/facebook/react/pull/16381) and it might be tricky to import PRs that come in while this is in progress. 😄

Thanks for the offer, and we'll be happy to accept the contribution once the migration is done.

hristo-kanchev commented 5 years ago

Sure thing. 👍

gaearon commented 5 years ago

You can still start work and send a PR, but you'll have to re-submit it to a proper place later.

bvaughn commented 5 years ago

Merging might also be tricky, as a bunch of files are being moved around. Just thought it would be easier to wait a couple of days 😄

gaearon commented 5 years ago

I don't mean it would be on you to merge :-)

I'm thinking @hristo-kanchev can do the work and send a PR. Then we can ask him to copy paste the specific files he touched, find their new places in React repo, and send a PR there. That shouldn't involve putting more work on your plate.

bvaughn commented 5 years ago

Nah, I didn't take it that way. I just wanted to safe Hristo the hassle of merging 😄

hristo-kanchev commented 5 years ago

Nice idea @gaearon . I'll prepare the code and get it ready for submission once we merge DevTools in the main react repo.

bvaughn commented 5 years ago

This repository is being merged into the main React repo (github.com/facebook/react). As part of this, I am moving all issues to that repository as well and closing them here.

This issue has been relocated to: https://github.com/facebook/react/issues/16466