search

bvaughn / react-highlight-words

React component to highlight words within a larger body of text
https://bvaughn.github.io/react-highlight-words/
MIT License
2.16k stars 170 forks source link

Added config, altered build script to generate UMD bundle #63

Closed asilberschneider closed 6 years ago

asilberschneider commented 6 years ago

We please need an UMD (AMD) version for our loader

bvaughn commented 6 years ago

Addressed my own PR feedback and released as 0.14

bvaughn commented 6 years ago

Should be fine! The name doesn't affect the CJS build because the default export just gets assigned to whatever variable name the user defines :) Thanks!

On Thu, Aug 23, 2018, 5:43 PM Alexander Silberschneider < notifications@github.com> wrote:

@asilberschneider commented on this pull request.

In webpack.config.dist.umd.js https://github.com/bvaughn/react-highlight-words/pull/63#discussion_r212466779 :

@@ -0,0 +1,11 @@ +const baseDistConfig = require('./webpack.config.dist.base') +const _ = require('lodash') + +const umdDistConfig = {

  • output: {
  • filename: '[name].umd.js',
  • libraryTarget: 'umd'

I just kept the externals and the output library name as they previously were for the cjs configuration. The resulting output file has been successfully tested in conjunction with the dojo 1.x AMD loader and a custom built bundler. Please advise if I should have a further look at it :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bvaughn/react-highlight-words/pull/63#discussion_r212466779, or mute the thread https://github.com/notifications/unsubscribe-auth/AABznZXQMFKD7tsv8uzQYCBU_-OBxgRRks5uTyHlgaJpZM4WJuG3 .