Version 1.0 release - Githubissues

bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/

MIT License

3.87k stars 135 forks source link

Version 1.0 release #230

Closed bvaughn closed 9 months ago

bvaughn commented 10 months ago

Checklist:

[x] Remove pixel size constraints
[x] Replaced dataAttributes prop with ...rest (to support all HTMLAttributes)
[x] Review and pull in changes from open PRs:
- [x] #228
- [x] #224
[x] Audit open issues and close ones that are no longer releveant
[x] Remove any unnecessary async initialization logic necessitated by pixel constraints

I think this library's feature set is stable enough in my mind for a 1.0 release. It might be controversial but I have decided to cut pixel-based constraints from that release as they added too much complexity to the initialization and validation logic.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-resizable-panels	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2023 2:51am

tsufiev commented 9 months ago

@bvaughn is there a possibility that you could consider putting back pixel constraints into the library in the future, given a simpler and more straightforward solution would be found?

bvaughn commented 9 months ago

It's possible but it's not a priority for me.

NMinhNguyen commented 9 months ago

Are there any userland workarounds to be able to enforce minimum or maximum size in pixels?

bvaughn commented 9 months ago

From the README on this PR:

Can panel sizes be specified in pixels?

No. Pixel-based constraints added significant complexity to the initialization and validation logic and so I've decided not to support them. You may be able to implement a version of this yourself following a pattern like this but it is not officially supported by this library.