search

bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/
MIT License
3.87k stars 135 forks source link

Feature Request: Add default values for dom util methods #262

Closed psychedelicious closed 8 months ago

psychedelicious commented 8 months ago

The util methods in https://github.com/bvaughn/react-resizable-panels/tree/main/packages/react-resizable-panels/src/utils/dom should probably have default values.

Using document would retain the previous behaviour, with some minor changes to the types (widening HTMLElement to ParentNode | HTMLElement.

bvaughn commented 8 months ago

This would have been worth doing initially, but I don't know if this change is worth making now that the release has already been made.

psychedelicious commented 8 months ago

Wouldn't be surprised if we are the only project that started using these methods before v1.0.8 - likely very minor impact from the breaking change. No worries if you'd like to leave things as-is.

bvaughn commented 8 months ago

I'll give it a little thought. :)

bvaughn commented 8 months ago

Released in react-resizable-panels@1.0.9

❤️ → ☕ givebrian.coffee