search

bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/
MIT License
3.87k stars 135 forks source link

onDragging to much calls #287

Closed damaafer closed 7 months ago

damaafer commented 7 months ago

Does I misuse PanelResizeHandle's onDragging prop ?

Excepted behavior: onDragging is only call when it's PanelResizeHandle is effectively dragged.

Actual behavior: Any click anywhere on the page triggers onDragging callback of every PanelResizeHandle.

Repro: https://codesandbox.io/p/sandbox/react-resizable-panels-forked-t6cmkx (open the console and click anywhere on the page).

bvaughn commented 7 months ago

This is a bug. Will try to release a fix shortly.

bvaughn commented 7 months ago

Fixed in 5afa01c and 6c74960; released in version 2.0.4

❤️ → ☕ givebrian.coffee

damaafer commented 7 months ago

Works great. Thank you for the quick fix 👍

paulm17 commented 1 month ago

Not sure if it's the same issue or a new one.

OnDragging doesn't do anything. But if you mouseover it triggers the onDragging event.