search

bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/
MIT License
3.6k stars 125 forks source link

Z Index issues #288

Closed websiddu closed 5 months ago

websiddu commented 5 months ago

I'm able to access the resize handle above a dialog or anything above the resize handle.

I tried a bunch of z-index changes, but nothing worked, is there a way to disable the resize highlight when a dialog is over the resize line?

Demo Area

Reproduction link https://codesandbox.io/p/devbox/clever-johnson-yl7sg4?workspaceId=3494ce51-f0e3-4621-b467-08e9f6142c44

bvaughn commented 5 months ago

Yeah, I think this is a bug in the recent PanelResizeHandleRegistry utility I wrote, to support resizing multiple panels at once. Will need to think about how best to handle z-index.

bvaughn commented 5 months ago

This is trickier than I had hoped.

I have a work in progress attempt on #291 but (a) I'm not sure how expensive calculating and comparing stacking order will be and (b) I'm not yet sure how to handle the case that breaks my e2e test (a panel interfering with a resize handle)

bvaughn commented 5 months ago

Fixed in c1aa2b0; available in version 2.0.5

❤️ → ☕ givebrian.coffee