search

bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/
MIT License
3.87k stars 135 forks source link

fix: cannot passed element id in `<Panel />` `<PanelGroup />`, `<PanelResizeHandle />` #299

Closed koralle closed 7 months ago

koralle commented 7 months ago

I found while writing a11y tests using axe-core that the <Panel />, <PanelGroup />, and <PanelResizeHandle /> ids are not being passed properly.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 5:48pm
bvaughn commented 7 months ago

I think this could be considered a breaking change 🤔 I think it may be safer to only pass through ids from props (ones explicitly assigned by users, not the auto-generated ones I use internally)

bvaughn commented 7 months ago

Thanks for the PR! This change just went out in 2.0.8

❤️ → ☕ givebrian.coffee