search

bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/
MIT License
3.58k stars 124 forks source link

BugFix: Global cursor style reset on unmount #313

Closed TAGC closed 4 days ago

TAGC commented 4 months ago

Fixes #308.

This PR updates the PanelResizeHandle component to call resetGlobalCursorStyle when unmounted. This should prevent the cursor from indefinitely retaining the "resize" style if the component is unmounted as a panel is being resized.

I've tested out these changes locally and they appear to resolve the issue.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 8:31pm
TAGC commented 3 months ago

Just an update on my end - work on this has been deprioritised as the team for the other frontend have found a workaround for the issue they were experiencing, and I've had higher priority stuff come through. I'd still like to continue on this when I get a chance, though.

bvaughn commented 3 months ago

Thanks for the update!

TAGC commented 1 week ago

Hi @bvaughn, would you be able to re-review this when you get a chance? It's not critical, but it would be useful for my hackday project.

bvaughn commented 4 days ago

Version 2.0.20 just deployed with this change.

TAGC commented 2 days ago

Thanks for taking this forward. I've updated my project to use v2.0.20 of this package and it's looking good to me :)