bvaughn / react-resizable-panels

https://react-resizable-panels.vercel.app/
MIT License
3.58k stars 124 forks source link

Record Playwright tests with Replay #348

Open bvaughn opened 2 months ago

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 1:50pm
bvaughn commented 2 months ago

@Andarist The latest v6 alpha looks to have both steps and metadata. Great!

bvaughn commented 2 months ago

Removing the test.only so that all of my tests run shows a new failure though:

RecordingUploadError: Failed to set recording metadata Error: Protocol client is not initialized

Andarist commented 2 months ago

Interesting, gonna investigate soon!

Andarist commented 1 month ago

We have a partial success here! It still suffers from the metadata size problem - but most tests don't exceed that size and recordings are nicely created. Could you also confirm that it works for you locally?

bvaughn commented 1 month ago

Could you also confirm that it works for you locally?

Yes, tests do run (although tests/StackingOrder.spec seems perhaps a bit flakier? could be a coincidence or could be a difference caused by the older Chromium version).

I think our runner's output is less helpful as you go. For instance, running these tests on main gives feedback as you go: Screenshot 2024-05-09 at 10 26 40 AM

Running them on this branch is more quiet: Screenshot 2024-05-09 at 10 27 16 AM

But that's a nit.

replay-io[bot] commented 1 month ago

Status Complete ↗︎
Commit eaa041f74c717d5dd37c60e8c5e86cb9590849b0
Results
1 Failed
  • should update cursor when dragged past the min/max size (like VS Code)
  • 23 Passed
  • earlier panels should be springy when expanding then collapsing the last panel
  • Enter key (collapsible)
  • Enter key (not collapsible)
  • Home and End keys
  • horizontal lists
  • implements optional F6 key functionality
  • later panels should be springy when expanding then collapsing the first panel
  • panels should remember a max spring point per drag
  • scenario: other maxSize(s)
  • scenario: other minSize(s)
  • scenario: own maxSize
  • scenario: own minSize
  • should call onResize when panels are resized
  • should not update cursor or start dragging if a resize handle is underneath another element
  • should not update cursor style for resizes caused by keyboard events
  • should remember the most recent expanded size for collapsed panels
  • should resize and maintain layouts independently
  • should restore previous layout if autoSaveId prop has been provided
  • should set 'data-resize-handle-active' attribute when active
  • should store layouts separately per panel combination
  • should support custom collapsedSize values
  • should update cursor when dragging intersecting panels (like tmux)
  • vertical lists