fix: React deprecated findDOMNode method in Table - Githubissues

bvaughn / react-virtualized

React components for efficiently rendering large lists and tabular data

http://bvaughn.github.io/react-virtualized/

MIT License

26.31k stars 3.05k forks source link

fix: React deprecated findDOMNode method in Table #1704

Closed reliveyy closed 1 month ago

reliveyy commented 2 years ago

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

[x] The existing test suites (npm test) all pass
[x] For any new features or bug fixes, both positive and negative test cases have been added
[x] For any new features, documentation has been added
[x] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[x] Format your code with prettier (yarn run prettier).
[x] Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

This is a simple workaround for https://github.com/bvaughn/react-virtualized/issues/1353.

olliechick commented 2 years ago

@bvaughn is it possible to merge this PR? It is a small fix that removes strict-mode error

cuong-tech commented 1 year ago

@bvaughn any chance we could merge this before EoY please?

Npervic commented 1 year ago

Any chance of anyone reviewing this?

saidmashhud commented 7 months ago

@bvaughn merge this pr plz

Noahkoole commented 5 months ago

Please merge this @bvaughn