search

bvaughn / react-virtualized

React components for efficiently rendering large lists and tabular data
http://bvaughn.github.io/react-virtualized/
MIT License
26.31k stars 3.05k forks source link

windowScroller/utils/onScroll import an useless variable #1736

Closed PengYYYYY closed 2 years ago

PengYYYYY commented 2 years ago

Bug Report

What is the current behavior?

npm package windowScroller/utils/onScroll import an useless variable.in my vite environment import error。

image

What is the expected behavior?

There is no bpfrpt_proptype_WindowScroller in es/windowScroller/utils/onScroll

Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?
react-virtualized 9.22.3
PengYYYYY commented 2 years ago

https://github.com/remorses/react-virtualized-fixed-import#9.22.3

abemedia commented 8 months ago

I wrote an esbuild plugin to fix this by stripping out the offending line at build time, rather than having to use a patched package: https://npmjs.com/package/esbuild-plugin-react-virtualized