chore: Add support for react ^17.0.0 and ^18.0.0

rebelliard commented 2 years ago

Adds React ^17 and React ^18 as allowed peer dependencies, so that apps using this library can upgrade React without having to override any dependencies.

This pull request should superseed https://github.com/bvaughn/react-virtualized/pull/1656.

[x] The existing test suites (npm test) all pass
[x] For any new features or bug fixes, both positive and negative test cases have been added
[x] For any new features, documentation has been added
[x] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[x] Format your code with prettier (yarn run prettier).
[x] Run the Flow typechecks (yarn run typecheck).

rebelliard commented 2 years ago

Is it possible to publish a new version of this library? :D

PS: Thanks for the hard work here!

bvaughn commented 2 years ago

I'm not feeling up for that task right now. Since the last time I published a release, things have changed in master that I haven't tested and can't vouch for.

If you're feeling up for doing this, let's chat?

rebelliard commented 2 years ago

Sure! I should be able to look into it during the week. 🙂

rebelliard commented 2 years ago

Let me know how I can help. Have a nice day. 🙂

bvaughn commented 2 years ago

How you could help: You can make the NPM release and agree to watch and respond to any issues filed over the next few weeks that may have been caused by the release.

rebelliard commented 2 years ago

I can do that. If it makes sense to you, it's best then to push the NPM release on Monday, as I'll have a few AFK days at the end of this week, and I'd like to be here to respond. 🧐 👮‍♂️

bvaughn commented 2 years ago

Sounds good, Rafael. What's your NPM username btw?

rebelliard commented 2 years ago

Hey @bvaughn. I tried publishing the NPM package to no avail. I could have sworn I accepted the NPM invitation, but maybe but perhaps I didn't. Could you send it again? :)

❯ yarn publish

yarn publish v1.22.18
[1/4] Bumping version...
info Current version: 9.22.3
question New version: 9.23.0
info New version: 9.23.0
[2/4] Logging in...
[3/4] Publishing...

(…)

error Couldn't publish package: "https://registry.yarnpkg.com/react-virtualized: You do not have permission to publish \"react-virtualized\". Are you logged in as the correct user?"

❯ npm whoami

rebelliard

dgilbertdigital commented 2 years ago

Anyway to get this resolved @rebelliard , @bvaughn? I think this release would help out a lot of people

Akhil-Chandran-Arch commented 2 years ago

Anyway to get this resolved @rebelliard , @bvaughn? I think this release would help out a lot of people

yeah, waiting for the release

ezhilkarthi commented 2 years ago

Any update on the release @rebelliard @bvaughn with React 17 or 18 support.

JurajKavka commented 2 years ago

Hi any update on this?

cileria commented 2 years ago

Hallo, can you please prioritize this? React-window does not really do it for me. react-virtualized is a great library, react-window does not really do it for me.

enykeev commented 2 years ago

The changes have been published in a fork as https://www.npmjs.com/package/@enykeev/react-virtualized/v/9.22.4-mirror.1. Obviously use at your own discretion.

Also, be aware, this package has a ton of deprecated and vulnerable dependencies now. It needs active support if want to continue to rely on it.

gabycperezdias commented 2 years ago

@bvaughn Any ETA for the publishing? It appears as if the code is 100% stable for it to be published but it was just a permission issue (https://github.com/bvaughn/react-virtualized/pull/1740#issuecomment-1116395181)? Could we retry doing that?

cileria commented 2 years ago

The changes have been published in a fork as https://www.npmjs.com/package/@enykeev/react-virtualized/v/9.22.4-mirror.1. Obviously use at your own discretion.

Also, be aware, this package has a ton of deprecated and vulnerable dependencies now. It needs active support if want to continue to rely on it.

Thank you so much! How can I install type declarations of this package? I tried:

npm i @types/@enykeev/react-virtualized npm i @enykeev/@types/react-virtualized

Neither works. Any Idea?

enykeev commented 2 years ago

I have not published any type declarations. Given that the types have not changed, you should be able to use original declarations. You may need to somehow hint it to the ts/vscode.

taw1313 commented 1 year ago

How's this going?

ilinalexgit commented 1 year ago

ping @rebelliard @bvaughn

fwhatley commented 1 year ago

Any update on the publish for this change? or does anyone have suggestions of other libraries similar to this?

LitoMore commented 1 year ago

I opened an issue about this topic:

https://github.com/bvaughn/react-virtualized/issues/1775

tasawar-hussain commented 1 year ago

I'm not feeling up for that task right now. Since the last time I published a release, things have changed in master that I haven't tested and can't vouch for.

If you're feeling up for doing this, let's chat?

@bvaughn @rebelliard Instead of publishing the latest master branch, A new branch can be created from latest tag as base branch, make these changes in that branch and then create a new tag on that branch and publish the release, in this way only these changes would be part of the release.

I'd be happy to help!

ar53n commented 1 year ago

is there any updates?

rebelliard commented 1 year ago

Unfortunately, I was not given publishing rights.

npm ERR! 403 Forbidden - PUT https://registry.npmjs.org/react-virtualized - You do not have permission to publish "react-virtualized". Are you logged in as the correct user?

bvaughn commented 1 year ago

Version 9.22.4 has been published with peer dependencies updated to include React 17 and 18. (No other changes from 9.22.3)

https://github.com/bvaughn/react-virtualized/releases/tag/v9.22.4

bvaughn / react-virtualized

chore: Add support for react ^17.0.0 and ^18.0.0 #1740