React 18 Support - Githubissues

bvaughn / react-virtualized

React components for efficiently rendering large lists and tabular data

http://bvaughn.github.io/react-virtualized/

MIT License

26.1k stars 3.05k forks source link

React 18 Support #1746

Open Miikis opened 2 years ago

Miikis commented 2 years ago

Feature Request

Provide as much information as possible about your requested feature. Here are a few questions you may consider answering:

What's your use case? (Tell me about your application and what problem you're trying to solve.) Not sure but I think the virtualization is using react's synchronous dom-rendering apis still.
What interface do you have in mind? (What new properties or methods do you think might be helpful?) Same interface is fine — just need React 18 support.
Can you point to similar functionality with any existing libraries or components? (Working demos can be helpful.) Not sure if react-window has a similar incompatibility w/ React 18

tippfelher commented 2 years ago

Used react-virtualized with React 18 two days ago. Why do you think it doesn't work?

Miikis commented 2 years ago

@tippfelher some features might work but I think some operations that have to do w/ figuring out the size of DOM elements (e.g. CellMeasurer) are performed synchronously and/or in an incompatible way w/ React 18. But this is just a guess at this point — would be nice to get some insight from @bvaughn on this.

The real answer to your question, I guess, is I tried to upgrade to react@18.0.2 while using react-virtualized@9.22.3 and the virtualized grid — where we're def using features that would require determining cell-size — wouldn't render.

On a whim, I also tried react-virtualized@10.0.0-alpha.17 but it led to the same results. That alpha release is available on npm but there's no mention of it in the changelogs — so I don't what's supposed to be in it.

distinctdan commented 2 years ago

The CellMeasurer does support using a ref to measure its child instead of the default way. I think that's the recommended way that's compatible with future versions of React.

marcjoancr commented 2 years ago

I made it work using npm install react-virtualized --legacy-peer-deps

Flouwrian commented 2 years ago

I made it work using npm install react-virtualized --legacy-peer-deps

This also worked for me

andrewluetgers commented 2 years ago

any plans for a release that eliminates the need for --legacy-peer-deps

avegancafe commented 2 years ago

+1 to cutting a new release, looks like the version upgrade has been merged a month ago, would be very very nice to be able to use this lib again

yelnyafacee commented 2 years ago

does this has anything to do with issue #1737?

gormonn commented 1 year ago

When i use List in my project with React 18 + TypeScript, i got an error like this: https://github.com/bvaughn/react-virtualized/issues/1739

skye-levit commented 1 year ago

Any update on the request?

DrkCoater commented 1 year ago

Any update on this?

ahrakos commented 1 year ago

Any update?

yelnyafacee commented 1 year ago

there wont be any this package is dead, its been for many month now, the author have no intention to update it, even if it is possible

AgomohC commented 1 year ago

I made it work using npm install react-virtualized --legacy-peer-deps

This worked for me.

hiddenist commented 1 year ago

My TypeScript is very unhappy. Took me a bit to realize that it's because this lib doesn't support React 18 yet - I was getting errors the same as #1739 (which seems to be closed, even though the issue is still present on the latest release). Guess I'm going to go use something else.

muhaimincs commented 1 year ago

My TypeScript is very unhappy. Took me a bit to realize that it's because this lib doesn't support React 18 yet - I was getting errors the same as #1739 (which seems to be closed, even though the issue is still present on the latest release). Guess I'm going to go use something else.

what do you have as alternative?

AgomohC commented 1 year ago

My TypeScript is very unhappy. Took me a bit to realize that it's because this lib doesn't support React 18 yet - I was getting errors the same as #1739 (which seems to be closed, even though the issue is still present on the latest release). Guess I'm going to go use something else.

what do you have as alternative?

Try react virtuoso https://www.npmjs.com/package/react-virtuoso