NadiaIdris commented 1 year ago

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

[ ] The existing test suites (npm test) all pass Two tests are failing:
[x] For any new features or bug fixes, both positive and negative test cases have been added
[x] For any new features, documentation has been added
[x] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[x] Format your code with prettier (yarn run prettier).
[x] Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

PR Description

Added more info on how to fix AutoSizer height 0 issue if AutoSizer is a descendant of a flex container.

NadiaIdris commented 11 months ago

@reginadiana - Thanks for approving the PR. I was wondering when this might be merged (I don't have write access to this repo)?

reginadiana commented 11 months ago

@reginadiana - Thanks for approving the PR. I was wondering when this might be merged (I don't have write access to this repo)?

I think just the @bvaughn can approve :(

bvaughn / react-virtualized