search

bvdputte / kirby-fingerprint

Cache-busting utility to fingerprint assets (JS/CSS) in Kirby CMS
MIT License
15 stars 3 forks source link

Undefined variable $filename #12

Closed bezin closed 3 years ago

bezin commented 3 years ago

Hello there,

while I skimmed through your code my IDE showed me an undefined variable error in Fingerprint::Hash: https://github.com/bvdputte/kirby-fingerprint/blob/master/src/Fingerprint.php#L35

Best Benedict

bvdputte commented 3 years ago

Hi Benedict,

What exactly is undefined please? In case there's something fishy to $path or it's pathinfo, you shouldn't get to this line?

bezin commented 3 years ago

Hi Bart,

I am sorry, the link pointed to the wrong line. It is now fixed. In line 35 you return $filename which was never defined.

bvdputte commented 3 years ago

You're right. Seems to be leftover code that didn't do anything.

I've removed it. Thx 👍