search

bvibber / OGVKit

Ogg and WebM media playback for iOS
MIT License
216 stars 67 forks source link

encoder branch: rotated videos not handled #211

Closed bvibber closed 4 years ago

bvibber commented 6 years ago

Currently rotated videos end up in their raw orientation, which ain't good. WebM doesn't seem to have a rotation feature, so would need to rotate the input data.

bvibber commented 6 years ago

Need to check if rotation is a config attachment on the frames, or something global to the file, or what.

If AVSampleBufferDisplayLayer handles these as is then they might play ok, otherwise have to jump through some hoops.

For encoding, will probably need to rotate during the copy from the sample buffer (which will replace the OGVVideoBuffer currently exposed, after further refactoring) into the vpx_image.