search

bvibber / audio-feeder

Small JS library to abstract Web Audio raw PCM output
Other
53 stars 7 forks source link

Volume changes happen "late" in Flash backend #30

Closed bvibber closed 6 years ago

bvibber commented 6 years ago

the _resampleFlash function on FlashBackend applies volume multiplication at buffer time:

https://github.com/brion/audio-feeder/blob/master/src/flash-backend.js#L198

This causes changes to the volume parameter or mute state at runtime to appear to take affect late: https://github.com/brion/ogv.js/issues/490

Should instead apply multiplication of volume within the ActionScript code as each buffer goes out, so they apply as fast as possible.

bvibber commented 6 years ago

ugh, it does apply within the AS code as well? I'm confused about how this works now.