bvibber / hdrfix

tool for converting HDR screenshots to SDR with suitable tone-mapping
114 stars 10 forks source link

Watch File Ignores Parameters #3

Closed adfrost81 closed 2 years ago

adfrost81 commented 2 years ago

I've been using this with screenshots from Mass Effect Andromeda. After settling on some optimal settings, I updated the watch.bat file with them, and started taking some screenshots. Afterwards, I compared against some of my test images and they did not match. It appears as though it is ignoring whatever values are put in the batch file and just using the defaults.

Output from my settings: Mass Effect Andromeda Screenshot 2021 10 03 - 00 45 06 33-ActualSettings

Output from watch.bat: Mass Effect Andromeda Screenshot 2021 10 03 - 00 45 06 33-sdr

Here's the batch file settings I used: watch.txt

bvibber commented 2 years ago

In general I would recommend against using --hdr-max=70 as this will place the maximum preserved HDR brightness level below the nominal SDR white level (80 nits).

I'm also not sure I understand what the difference between "output from [your] settings" and "with watch.bat" means. How did you run it with your settings if it wasn't by running the modified watch.bat? Did you run on a specific input file with those settings but not the --watch=. setting? Did you update the right watch.bat file? Did you close the previously running instance of the program?

adfrost81 commented 2 years ago

In general I would recommend against using --hdr-max=70 as this will place the maximum preserved HDR brightness level below the nominal SDR white level (80 nits).

I'm also not sure I understand what the difference between "output from [your] settings" and "with watch.bat" means. How did you run it with your settings if it wasn't by running the modified watch.bat? Did you run on a specific input file with those settings but not the --watch=. setting?

Correct. I experimented by passing parameters directly in the command line and observed the results. After trying many different variations, I settled on --hr-max=70 as that is provided results closest to what I saw in the game. I presumed was giving me an HDR Max of 70% since that is what worked best for me, but I'm open to this being incorrect/wrong syntax.

Did you update the right watch.bat file?

I copied the sample watch.bat file into the folder containing hdrfix.exe & the screenshots, replaced the sample settings, and saved it.

Did you close the previously running instance of the program?

I did not have an active instance running before running the hdrfix --watch=. command. Perhaps my syntax is incorrect and it is ignoring the watch.bat file entirely?

I should also state that I tried using the default settings you provided in the watch.bat file just to see what would happen, and it ignored those as well.

adfrost81 commented 2 years ago

I presumed was giving me an HDR Max of 70% since that is what worked best for me, but I'm open to this being incorrect/wrong syntax.

Update: I verified the syntax on the --hdr-max=70 command it is definitely not the same as --hdr-max=70%. That said, anything --hdr-max=350 and higher is indistinguishable from simply not using any parameters at all. At least on my monitor (a 48" LG C1).

adfrost81 commented 2 years ago

Closing this because I figured out what I was doing wrong, and thus confirmed it is working properly. Rather than running the batch file directly from the command line, I was using the following the following command: >hdrfix --watch=*

For some reason, I thought just having the batch file in the same directory as hdrfix would mean it would reference the file. Now obviously (once I thought about it more), it doesn't do that, which is why it wasn't doing anything. So I ran the >watch.bat and that of course worked.