search

bvieth / powsimR

Power analysis is essential to optimize the design of RNA-seq experiments and to assess and compare the power to detect differentially expressed genes. PowsimR is a flexible tool to simulate and evaluate differential expression from bulk and especially single-cell RNA-seq data making it suitable for a priori and posterior power analyses.
https://bvieth.github.io/powsimR/
Artistic License 2.0
103 stars 23 forks source link

Inconsistent arguments to functions #40

Closed csoneson closed 4 years ago

csoneson commented 4 years ago

Might be related to #35

The example at https://github.com/bvieth/powsimR/blob/62acf471ff202a0710632ebcc5ee709e87cb9254/R/Evaluate.R#L43-L53 doesn't run (with version 1.1.5), since the evaluateDist function does not provide a readData argument to .run.checkup. There are additional arguments that are not consistently added across the functions, e.g. Protocol, GeneFilter, SampleFilter.

bvieth commented 4 years ago

Dear Charlotte,

thank you for pointing out these bugs. While changing estimation functions, I forgot to drag those changes along for evaluateDist(). In the new version (1.2.0) this should be solved.

I will close this issue now, but if there are any further issues, feel free to reopen / message again.

Kind regards Beate