search

bvilhjal / ldpred

MIT License
96 stars 57 forks source link

bug report on printing 'chrom' #14

Closed bastia0321 closed 6 years ago

bastia0321 commented 6 years ago

https://github.com/bvilhjal/ldpred/blob/dbe971d8b8dc0cb676b286a45499c7ff3a3fa9b6/ldpred/coord_genotypes.py#L1003

Here the variable chrom is of type string rather than integer.

bvilhjal commented 6 years ago

Thanks for noting this. I'm finally finding time to fix these things.

rbpeng commented 5 years ago

Hey @bvilhjal, thank you for your work in maintaining LDpred!

I think I found another issue similar to this one. In line 992, I think the %d in g = ssg.create_group('chrom_%d' % chrom) should be replaced with %s. Line 670 has the same issue. I was having issues with getting the BASIC format to work, but coord_genotypes.py seemed to work after I fixed this.

bvilhjal commented 5 years ago

I fixed this as well now, thanks.

marielohcs commented 5 years ago

FYI - Don't think it is fixed for Line 670 :) Only line 992