Integrate Tyler's changes into main code

bvkrauth / rcr

RCR package for Stata, R, and Python

MIT License

0 stars 2 forks source link

Integrate Tyler's changes into main code #1

Closed bvkrauth closed 4 years ago

bvkrauth commented 4 years ago

Tyler's Gnu/Linux port included some Gnu/Linux-only changes, some formatting changes, and some minor enhancements. Need to update my main (Windows IFC) code to integrate (most of) these changes. Tasks:

[x] Integrate formatting changes so that all differences are substantive
[x] Compile and test
[ ] Review other changes and choose which ones to integrate

bvkrauth commented 4 years ago

One change is that == was replaced with .eqv. in logical expressions. This is both good practice and required for GCC (see https://gcc.gnu.org/onlinedocs/gcc-3.4.6/g77/Equivalence-Versus-Equality.html) so I will integrate that change

bvkrauth commented 4 years ago

Another change is that rcr.f90 now references modules rcrlib_gnu and rcrutil_gnu rather than rcrlib and rcrutil. I have broken this out into a new issue #2.

bvkrauth commented 4 years ago

Finally, Tyler made two important changes to rcr.ado:

Replaced references to the windows executable to references to the linux executable
- I have broken this out into a new issue #3
Added code to increase the maximum number of control variables from 27 to 102.
- I have broken this out into a new issue #4

bvkrauth commented 4 years ago

Last change needed is to update the certification script (see #5)