search

bvlaicu / coned

Utility to interact with a ConEdison smart energy meter
Apache License 2.0
51 stars 16 forks source link

Correcting endpoint URL and dealing with leading zeros in meter numbers shown on bills #3

Closed reriley closed 3 years ago

reriley commented 3 years ago

Firstly, thanks for this awesome tool!

Using the module I had two issues that had me stumped for a little while. This is my attempt to add resilience to user inputs and correct opower endpoint URL issue. Also my first Github pull request so learning as I go.

  1. Fixed issue with 'coned' being passed for opower endpoint URL instead of 'cned'.

  2. Fixed error with leading zeros in meter number as shown on CONED bill but not represented in the opower endpoint URL.

Not tested with ORU.

reriley commented 3 years ago

Thanks. I agree your naming suggestion makes more sense.