Ballista versus clear land

bvschaik / julius

An open source re-implementation of Caesar III

GNU Affero General Public License v3.0

2.83k stars 316 forks source link

Closed 411752230 closed 4 years ago

411752230 commented 4 years ago

Clicking clear land makes ballista disappear and getting out of clear land makes the ballista reappear

crudelios commented 4 years ago

Bug related to #120.

devnoname120 commented 4 years ago

Can you confirm that it doesn't happen in the original game?

411752230 commented 4 years ago

Can you confirm that it doesn't happen in the original game?

Confirmed. It doesn't happen in the original game

bvschaik commented 4 years ago

I think I found the problem but I'm not at my computer so I can't check. https://github.com/bvschaik/julius/blob/a72272eff3f1de7d93e5ca7e28d85b8c3816128b/src/widget/city_without_overlay.c#L440-L453 Here we draw everything in one pass, instead of multiple passes like in the non-deletion code. This causes the tower to be drawn on top of the ballista. @crudelios Could you perhaps take a look?

crudelios commented 4 years ago

Sure, I'm thinking about implementing visual feedback for overlays anyway,I'll do it in one go.

bvschaik commented 4 years ago

Hippodrome still has issues with the horses walking in front of the pillars and fire columns.

crudelios commented 4 years ago

I didn't notice that! Easy fix though, you've done it already.