search

bvschaik / julius

An open source re-implementation of Caesar III
GNU Affero General Public License v3.0
2.84k stars 317 forks source link

use devkitPro cmakery #708

Closed WinterMute closed 1 year ago

WinterMute commented 1 year ago

Use devkitPro cmakery to build project for switch.

bvschaik commented 1 year ago

Please also update the github actions scripts in .ci_scripts.

What's the benefit of using cmakery over the current approach?

WinterMute commented 1 year ago

Sorry, I hadn't noticed the old docker tag which doesn't contain the full cmakery scripts.

The advantage over the current approach is it's using the extensive cmake support we maintain for the platforms we target. This hopefully provides more examples of using our infrastructure which more homebrewers can take advantage of which hopefully means we find standard processes propagating and people experiencing less issues building homebrew projects.

Standardisation and flattening of build environments helps everyone in the end.

There are some more tweaks I'd like to make - for instance using pkg-config to find libraries rather than specifying them manually should avoid issues if & when we update dependencies for SDL.

WinterMute commented 1 year ago

What's up with the last two workflows? What's triggered those?

image
bvschaik commented 1 year ago

What's up with the last two workflows? What's triggered those?

Both are triggered by you pushing to your branch. The workflows have to be approved by one of the maintainers before they're run, since this is your first contribution to Julius, hence the warning icon.

Thanks for the explanation, I'll take a closer look this evening.

WinterMute commented 1 year ago

Thanks for merging.

crudelios commented 1 year ago

@WinterMute This seems like a good addition.

Do you mind also doing it for Augustus, please?

It has the added challenge that it needs to add files to romfs on build.