bvschaik / julius

An open source re-implementation of Caesar III
GNU Affero General Public License v3.0
2.84k stars 317 forks source link

Unable to correctly detect translation files in subdirectory on linux (case sensitivity issue) #710

Closed gryffus closed 11 months ago

gryffus commented 11 months ago

With following data structure (all lowercase), Julius correctly detects Czech subfolder and everything works as expected:

~/.julius> ls ./*.555 ./*.sg2 ./*.eng ./*.emp
./bigpeople.555   ./c3map_north.sg2  ./c3_south.555   ./europe01.555  ./load4.555          ./picture1.555
./briefing1a.555  ./c3map_north.555  ./c3title.555    ./europe02.555  ./mapback.555        ./picture2.555
./carthage.sg2    ./c3map.sg2        ./c32.emp        ./gaul.sg2      ./map_panels.555     ./picture3.555
./carthage.555    ./c3map_south.sg2  ./c3.555         ./gaul.555      ./north african.sg2  ./picture4.555
./celts.sg2       ./c3map_south.555  ./demo1.555      ./goths.sg2     ./north african.555  ./picture5.555
./celts.555       ./c3map.555        ./demo2.555      ./goths.555     ./panelwindows.555   ./picture9.555
./ckit.555        ./c3_mm.eng        ./demo3.555      ./greek.sg2     ./persians.sg2       ./scoreb.555
./c3.emp          ./c3_north.sg2     ./egyptians.sg2  ./greek.555     ./persians.555       ./senate.555
./c3.eng          ./c3_north.555     ./egyptians.555  ./load1.555     ./phoenician.sg2     ./the_empire.555
./c3_map.eng      ./c3.sg2           ./etruscan.sg2   ./load2.555     ./phoenician.555     ./title.555
./c3_map_mm.eng   ./c3_south.sg2     ./etruscan.555   ./load3.555     ./picture0.555

~/.julius> ls Czech/
c3.eng      c3_map_mm.eng    c3map.sg2        c3_mm.eng     c3_north.555  c3_south.sg2  c3.555  wavs
c3_map.eng  c3map_north.sg2  c3map_south.sg2  c3_north.sg2  c3.sg2        c3_south.555  smk

obrazek

Now let's rename for example Czech/c3.eng to Czech/C3.eng (on a case sensitive filesystem):

~/.julius> mv Czech/c3.eng Czech/C3.en

Game now detects the language folder, however fails to find the file. This happens to all files with various impacts.

obrazek

Is it possible to improve this to improve compatibility?

Thanks!

crudelios commented 11 months ago

This shouldn't be happening as the game accounts for case sensitivity.

I'll have a look at what's going on.

crudelios commented 11 months ago

Found the issue, it was a small oversight.

Should be fixed now!

gryffus commented 11 months ago

Wow that was fast, thanks a lot!