search

bvschaik / julius

An open source re-implementation of Caesar III
GNU Affero General Public License v3.0
2.79k stars 311 forks source link

Building Julius locally - works but executable doesn't show change #723

Closed adysuciu closed 6 months ago

adysuciu commented 7 months ago

Hi, First of all: Congrats for the work to replicate C3 - one of my favorite games! I wanted to play on my MacOS10.12 and built it from source successfully.

Now I want to play with the source code and see changes in the game. Cmake works and builds julius.app correctly, still I can see no change in the game.

Made a local branch and committed the change locally. Commit # 1cabf8 [adibranch 1cacbf8] want to check game Image attached.

Screen Shot 2024-02-04 at 21 07 06

I do not have too much experience with cmake, maybe I am missing some steps to propagate the source change.

Thanks in advance!

crudelios commented 7 months ago

I'm not sure what change you made, but for the app to update you don't need to commit but rather to use the make command again.

adysuciu commented 7 months ago

I have updated city/data.c and changed values for city_data.labor.wages_rome = 50; city_data.labor.wages = 50; city_data.finance.tax_percentage = 10;

After building I am expecting to see the new values in the Advisor Labor screen.

crudelios commented 7 months ago

Ah, I see the issue.

Those variables are updated every time the simulation runs and also during game load, so likely they are getting overwritten.

bvschaik commented 6 months ago

The variables you change indeed get overwritten on save load. You will see the changes only when you start a new game through the City Construction Kit.

Considering that the main menu shows the new commit hash in the version string in the bottom left corner, the source changes have been compiled: I'm closing this as fixed.