bw2 / ConfigArgParse

A drop-in replacement for argparse that allows options to also be set via config files and/or environment variables.
MIT License
719 stars 121 forks source link

Python 3.5-support and f-strings #289

Open osirisinferi opened 10 months ago

osirisinferi commented 10 months ago

A user of the EFF application Certbot had an issue with a syntax error on their system running Python 3.5 due to configargparse using f-strings, which were introduced in Python 3.6.

Currently, there are 3 usages of f-strings in configargparse.py, introduced in https://github.com/bw2/ConfigArgParse/commit/4937771c59dbb0878e6852fb1fb927ce36f3a5de, which landed in v1.4.

Also currently, ConfigArgParse claims support for Python 3.5. But that would have been leading to syntax errors on Python 3.5 for more than 2 years now.

My suggestion would be to drop support for Python 3.5 entirely, as those users would simply get a syntax error when the module is imported.