Open JustKiddingCode opened 1 year ago
Hi, thank you for the PR. I took a first look on it and have some comments and remarks to be adressed. Maybe you have already identified some of my points and maybe we need some more detailed testing and validation of this feature.
General structure and categorization:
filegate
segments suits better to the already existing testing
directory/category instead of a new category like dev.diskbuffer
segment will be better categorized within the controlflow
category. i think its rather an offloading and manipulation of the control-flow in the current flowpipeline instanceDiskbuffer segment
diskbuffer.go
line 89 is probably reading the wrong configuration variablefilesize
is reached. (after debug log in line 298 was triggered)
Allows to buffer flows in memory and (additionally) on disk in zstd compressed files.
Add a small segment (filegate) for testing purposes to pause the pipeline when a file exists.