search

bwaidelich / Wwwision.PrivateResources

A Neos Flow package that allows for protecting persistent resources from unauthorized access.
MIT License
10 stars 10 forks source link

FEATURE: Flow 7+ compatibility #21

Closed andrehoffmann30 closed 3 years ago

bwaidelich commented 3 years ago

@andrehoffmann30 thanks for this. Just to make sure. Did you test that this package actually works with Flow 7+?

andrehoffmann30 commented 3 years ago

Hi @bwaidelich I am still working on it therefore I started a draft merge request. As so as everything is ready, I will change this to a normal merge request and write you, so that you can review the code. I added a WIP so that everyone can see directly that I am still working on this MR.

andrehoffmann30 commented 3 years ago

Hi @bwaidelich, in my view this pr is ready to be reviewed. I test it in a project of a customer of my company and it seems to work as expected. Can you pleas review the code and test it? If you have any suggestions to improve the code or find any problems, please write me. Thank you.

bwaidelich commented 3 years ago

@andrehoffmann30 Wow, thanks a lot for your contribution. Unfortunately I don't have the time to test this right now and I'm in vacation from tomorrow. But the code looks great and you even took the time to adjust the README <3

I'll go ahead, merge this into master and release a 6.0.0 – If we come across some bugs, we can always fix them in a patchlevel release.

Thanks again!