search

bwangpj / pe

0 stars 0 forks source link

Overzealous input validation in `find_nric` #3

Open bwangpj opened 12 months ago

bwangpj commented 12 months ago

It is overzealous to restrict only to The NRIC must start with 'S' or 'T' and contain 7 digits between the 2 alphabets. in the find_nric command.

In the real-world setting, for instance due to PDPA, the user does not always have access to the full NRIC of the patient.

nus-pe-bot commented 11 months ago

Team's Response

NRICs are required by law to be given when seeking medical treatment at a general practitioner clinic, under the Private Hospitals and Medical Clinics Regulations.

Regarding the NRIC restriction, see #41.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: Not clear how this is a documentation bug, as it is not related to any documentation?

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]