search

bwarren2 / datadrivendota

Codebase for dota analytics
Other
0 stars 0 forks source link

Task upgrade #539

Closed bwarren2 closed 8 years ago

bwarren2 commented 8 years ago

Clean up the core API call code to use requests and handle error codes correctly.

Currently, there is a mess of presumed functionality based on the result of the api call and the api context, ex in the ApiFollower base task. These should be streamlined into more monad-style functionality. A core problem: the tasks that get run are not the same as the tasks that get instantiated in celery, so information needs to be passed around in the function signatures (and ingested in call if necessary).

bwarren2 commented 8 years ago

Can we sync-chat about how to manage the monad signatures? Managing the calling signatures for things like ApiFollower in the class call seems cleaner, but I would like to talk it out be sure I understand what is going on,

wlonk commented 8 years ago

:tea: when ready.